Bump go-containerregistry to latest version #1882
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
| k8s.io/apimachinery v0.0.0 | ||
| k8s.io/client-go v0.0.0 | ||
| k8s.io/code-generator v0.0.0 | ||
| k8s.io/api v0.17.0 |
There was a problem hiding this comment.
Can't make go not changing thoses (go mod tidy & co always add this one…) It doesn't matter as they are replaced.. it's just a pain…
There was a problem hiding this comment.
So, we have to keep replacing them manually?
There was a problem hiding this comment.
For now I think so… I am hoping we won't, I need to try something out.. but I think until we bump to 1.15 (v0.15) or 1.17, we will still need the replace (but I might be wrong, I'll try that when I bump to 1.15 👼 )
|
/hold Something is fishy though.. I don't get why there is |
tekton-robot
added
the
do-not-merge/hold
|
oups.. I need to add a |
vdemeester
force-pushed
the
bump-go-containerregistry
branch
from
fc53414 to
0509032
Compare
Interesting.. which version did it take… |
vdemeester
force-pushed
the
bump-go-containerregistry
branch
from
0509032 to
d19602a
Compare
This allows to fix the OpenShit + GCP bug **and** it also removes the dependency on `k8s.io/kubernetes` that is a pain when upgrading to new kubernetes version. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
bump-go-containerregistry
branch
from
d19602a to
d8a627d
Compare
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
| k8s.io/apimachinery v0.0.0 | ||
| k8s.io/client-go v0.0.0 | ||
| k8s.io/code-generator v0.0.0 | ||
| k8s.io/api v0.17.0 |
There was a problem hiding this comment.
So, we have to keep replacing them manually?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Changes
This allows to fix the OpenShit + GCP bug (#1742) and it also removes the
dependency on
k8s.io/kubernetesthat is a pain when upgrading to newkubernetes version.
See google/go-containerregistry#649
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and [backwards incompatible changes](http #1742s://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md#backwards-incompatible-changes) must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.